basics_basic-types

[wilzbach]

No description provided.

[wilzbach]

This was automatically imported from the base repo & has already been reviewed by @WebFreak001, but not finally merged.

@WebFreak001 feel free to hit merge if you agree that this is ready ;-)

[WebFreak001]

er I don't quite agree with the HTML indentations in there right now, I mean the code should also be good looking, not only the website

[WebFreak001]

or if thats actually the commit because that looks very buggy and it looks like it has mixed in some of the github website

[wilzbach]

er I don't quite agree with the HTML indentations in there right now, I mean the code should also be good looking, not only the website
or if thats actually the commit because that looks very buggy and it looks like it has mixed in some of the github website

Ah damn, seems like my auto-migration had bugs :/
Should be fixed now - sorry.

[WebFreak001]

Is this accurate though? A char is only 1 byte and represents a byte in a UTF-8 string, you might need multiple chars to represent 1 UTF-8 character. You have dchar for full characters without needing to have multiple of them.

This code for example works different than you might expect:

import std.stdio;
void main() {
    string s = "Ω";
    writefln("%s (%s)", s[0], cast(int) s[0]);
}

Output: � (206)

[wilzbach]

Is this accurate though?

I translated this literally:

The prefix u denotes unsigned types. char translates to UTF-8 characters, wchar is used in UTF-16 strings and dchar in UTF-32 strings.

https://github.com/dlang-tour/english/blob/master/basics/basic-types.md

A char is only 1 byte and represents a byte in a UTF-8 string, you might need multiple chars to represent 1 UTF-8 character. You have dchar for full characters without needing to have multiple of them.

The document is referring to code units here, e.g. from Wikipedia:

https://en.wikipedia.org/wiki/UTF-8

The encoding is variable-length and uses 8-bit code units. It was designed for backward compatibility with ASCII and to avoid the complications of endianness and byte order marks in the alternative UTF-16 and UTF-32 encodings
https://en.wikipedia.org/wiki/UTF-16
The encoding is variable-length, as code points are encoded with one or two 16-bit code units.
https://en.wikipedia.org/wiki/UTF-32
It is a protocol to encode Unicode code points that uses exactly 32 bits per Unicode code point.

Maybe we should edit the base document to make it a bit clearer that code units are referred to?
FYI it's explained in more details on the strings page and since yesterday the DTour has a new gem on Unicode

[WebFreak001]

Hm we would need to change it in the english version too. Otherwise the translation here is done, gonna merge

[wilzbach]

Hm we would need to change it in the english version too. Otherwise the translation here is done, gonna merge

Opened it as issue, s.t. we don't forget:

dlang-tour/english#68

[wilzbach]

Thanks @WebFreak001!
One minor thing that I forgot to mention (shame on me) Could you maybe use the squashing feature (you should be able to select it after you click the merge button once) next time? No need to keep my review fix commits ;-)

[WebFreak001]

oh ok, didnt know about that feature on the website