Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend and beautify the Phobos style guide #1578

Merged
merged 1 commit into from
Feb 21, 2017

Conversation

wilzbach
Copy link
Member

@wilzbach wilzbach commented Feb 21, 2017

(follow up to dlang/phobos#5169)

  • Use H4 sections instead of nested lists
  • Applied better grouping
  • Moved unittest requirement to own "Template" group
  • Created a group "Brackets" for "Braces" and "Parentheses"
  • Added:
    • avoid unnecessary parentheses
    • space between binary operators, cast or lambdas
    • no space after unary operators, assert and function calls
  • Fixed function declaration in the style example

CC @andralex

- Use H4 sections instead of nested lists
- Apply better grouping
 - Moved unittest requirement to own "Template" group
 - Created a group "Brackets" for "Braces" and "Parentheses"
- Added:
  - avoid unnecessary parentheses
  - space between binary operators, cast or lambdas
  - no space after unary operators, assert and function calls
- Fix function declaration in the style example
Copy link
Member

@andralex andralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@andralex andralex merged commit c39aa29 into dlang:master Feb 21, 2017
@wilzbach wilzbach deleted the add-assert-style branch December 18, 2017 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants