Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge remote-tracking branch 'upstream/stable' into merge_stable #1868

Merged
merged 3 commits into from
Aug 17, 2017

Conversation

MartinNowak
Copy link
Member

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @MartinNowak!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Member

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of issues marked as fixed are not really fixed.

$(BUGSTITLE DMD Compiler bugs,

$(LI $(BUGZILLA 4014): CodeView debug type info not linked in from library)
$(LI $(BUGZILLA 11881): -betterC switch suffers from bit rot)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bug is combination of many enhancement requests, only small portion of which were addressed for this release. I think we should reopen it. (The biggest unaddressed issue is that you still get link errors regarding TypeInfo, which exactly what the description of the bug talks about.)

$(LI $(BUGZILLA 15759): chunks should work with only an input range)
$(LI $(BUGZILLA 15771): FileLogger should create the output directory if it does not exist)
$(LI $(BUGZILLA 16062): Add 'clear' method to OutBuffer $(LPAREN)std.outbuffer$(RPAREN))
$(LI $(BUGZILLA 16744): We should have a TypeOf template so that typeof can be used with templates like staticMap)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of TypeOf was reverted: dlang/phobos#5664
(Just reopened the bug.)

$(LI $(BUGZILLA 16856): D does not work on FreeBSD current $(LPAREN)what will eventually be 12$(RPAREN) due to libunwind)
$(LI $(BUGZILLA 17609): core.demangle demangles delegate variables as functions)
$(LI $(BUGZILLA 17610): core.demangle shows return type of template alias parameter)
$(LI $(BUGZILLA 17611): core.demangle cannot demangle delegates with function attributes)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these mangling related bug fixes depend on Rainer's unmerged dmd PR, or the merged druntime PR is sufficient?

@MartinNowak
Copy link
Member Author

Let's just reopen the marked bugs, we'll later regenerate the changelog anyhow.

@MartinNowak MartinNowak dismissed PetarKirov’s stale review August 17, 2017 08:30

Bugzilla issues are auto-generated.

@MartinNowak MartinNowak merged commit e717f48 into dlang:master Aug 17, 2017
@MartinNowak MartinNowak deleted the merge_stable branch August 17, 2017 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants