Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix Issue 16744: Add Typeof" #5664

Merged
merged 1 commit into from
Jul 31, 2017
Merged

Revert "Fix Issue 16744: Add Typeof" #5664

merged 1 commit into from
Jul 31, 2017

Conversation

wilzbach
Copy link
Member

Reverts #5662 as this hasn't been approved by @andralex

@jmdavis the simplest question is: since it's a trivial one-liner, why not just ask the user to do it if they have a need? We need to have a case for high frequency of use.

#4920 (comment)

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Auto-close Bugzilla Description
✓ 16744 We should have a TypeOf template so that typeof can be used with templates like staticMap

@wilzbach wilzbach mentioned this pull request Jul 31, 2017
Merged
dnadlinger
dnadlinger approved these changes Jul 31, 2017
View reviewed changes
Copy link
Member

@dnadlinger dnadlinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the original PR, this was perhaps merged a bit hastily. Also missing docs.

@dlang-bot dlang-bot merged commit f0eaf44 into master Jul 31, 2017
@dnadlinger dnadlinger deleted the revert-5662-MetaLang-patch-1-3 branch July 31, 2017 23:16
@PetarKirov PetarKirov mentioned this pull request Aug 17, 2017
Merged
MetaLang added a commit that referenced this pull request Oct 18, 2017
@MetaLang
Fix Issue 16744: Add Typeof (Redux)
e6d1fc2 
Previous PR: #5662. I'm resubmitting this after it was reverted in #5664.

This an alternative implementation to #4920.
@MetaLang MetaLang mentioned this pull request Oct 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnadlinger dnadlinger dnadlinger approved these changes

@andralex andralex andralex approved these changes

@MetaLang MetaLang MetaLang approved these changes

@PetarKirov PetarKirov Awaiting requested review from PetarKirov PetarKirov is a code owner

Assignees
No one assigned
Labels
auto-merge Enhancement
Projects
None yet
Milestone
No milestone
5 participants
@wilzbach @dlang-bot @dnadlinger @andralex @MetaLang