fix Issue 17843 - -betterC struct with field generates references to …

…TypeInfo
dlang · Nov 30, 2017 · 1d2da66 · 1d2da66
1 parent e58519e
commit 1d2da66
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 5 deletions.
diff --git a/src/ddmd/clone.d b/src/ddmd/clone.d
@@ -695,8 +695,9 @@ private bool needToHash(StructDeclaration sd)
         }
         if (tv.isfloating())
         {
-            // This is necessray for:
-            //  1. comparison of +0.0 and -0.0 should be true.
+            /* This is necessary because comparison of +0.0 and -0.0 should be true,
+             * i.e. not a bit compare.
+             */
             goto Lneed;
         }
         if (tv.ty == Tarray)

diff --git a/src/ddmd/dsymbolsem.d b/src/ddmd/dsymbolsem.d
@@ -5473,9 +5473,12 @@ private extern(C++) final class DsymbolSemanticVisitor : Visitor
         buildOpAssign(sd, sc2);
         buildOpEquals(sd, sc2);
 
-        sd.xeq = buildXopEquals(sd, sc2);
-        sd.xcmp = buildXopCmp(sd, sc2);
-        sd.xhash = buildXtoHash(sd, sc2);
+        if (global.params.useTypeInfo)  // these functions are used for TypeInfo
+        {
+            sd.xeq = buildXopEquals(sd, sc2);
+            sd.xcmp = buildXopCmp(sd, sc2);
+            sd.xhash = buildXtoHash(sd, sc2);
+        }
 
         sd.inv = buildInv(sd, sc2);
 

diff --git a/test/runnable/cassert.d → test/runnable/betterc.d b/test/runnable/cassert.d → test/runnable/betterc.d
@@ -10,6 +10,17 @@ void test(int ij)
     assert(ij,"it is not zero");
 }
 
+/*******************************************/
+// https://issues.dlang.org/show_bug.cgi?id=17843
+
+struct S
+{
+    double d = 0.0;
+    int[] x;
+}
+
+/*******************************************/
+
 extern (C) int main()
 {
     test(1);