Merge pull request #5866 from mathias-lang-sociomantic/fix-14411

Fix issue 14411 - Make implicit switch case fallthrough an error
dlang · Jun 14, 2016 · 6e2bf76 · 6e2bf76
2 parents 4a7dbcd + b76b0ce
commit 6e2bf76
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/statement.d b/src/statement.d
@@ -298,7 +298,7 @@ extern (C++) abstract class Statement : RootObject
                     {
                         //printf("result = x%x\n", result);
                         //printf("s: %s\n", s->toChars());
-                        if (global.params.warnings && result & BEfallthru && slast)
+                        if (result & BEfallthru && slast)
                         {
                             slast = slast.last();
                             if (slast && (slast.isCaseStatement() || slast.isDefaultStatement()) && (s.isCaseStatement() || s.isDefaultStatement()))
@@ -315,7 +315,7 @@ extern (C++) abstract class Statement : RootObject
                                 else
                                 {
                                     const(char)* gototype = s.isCaseStatement() ? "case" : "default";
-                                    s.warning("switch case fallthrough - use 'goto %s;' if intended", gototype);
+                                    s.error("switch case fallthrough - use 'goto %s;' if intended", gototype);
                                 }
                             }
                         }

diff --git a/test/fail_compilation/fail11653.d b/test/fail_compilation/fail11653.d
@@ -1,8 +1,8 @@
-// REQUIRED_ARGS: -w
+// REQUIRED_ARGS:
 /*
 TEST_OUTPUT:
 ---
-fail_compilation/fail11653.d(18): Warning: switch case fallthrough - use 'goto case;' if intended
+fail_compilation/fail11653.d(18): Error: switch case fallthrough - use 'goto case;' if intended
 ---
 */