fix Issue 15402 - allow private access to package symbols

dlang · Apr 9, 2016 · c424690 · c424690 · PetarKirov · Apr 9, 2016
1 parent 1aa8a1e
commit c424690
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/access.d b/src/access.d
@@ -492,7 +492,7 @@ extern (C++) bool symbolIsVisible(Module mod, Dsymbol s)
     case PROTundefined: return true;
     case PROTnone: return false; // no access
     case PROTprivate: return s.getAccessModule() == mod;
-    case PROTpackage: return hasPackageAccess(mod, s);
+    case PROTpackage: return s.getAccessModule() == mod || hasPackageAccess(mod, s);
     case PROTprotected: return s.getAccessModule() == mod;
     case PROTpublic, PROTexport: return true;
     }
@@ -533,7 +533,7 @@ extern (C++) bool symbolIsVisible(Scope *sc, Dsymbol s)
     case PROTundefined: return true;
     case PROTnone: return false; // no access
     case PROTprivate: return sc._module == s.getAccessModule();
-    case PROTpackage: return hasPackageAccess(sc._module, s);
+    case PROTpackage: return sc._module == s.getAccessModule() || hasPackageAccess(sc._module, s);
     case PROTprotected: return hasProtectedAccess(sc, s);
     case PROTpublic, PROTexport: return true;
     }

diff --git a/test/compilable/test15402.d b/test/compilable/test15402.d
@@ -0,0 +1,12 @@
+// REQUIRED_ARGS: -de
+
+struct S
+{
+    package int field;
+}
+
+void test()
+{
+    S s;
+    s.field = 1;
+}