fix Issue 12430 - non compile-time __simd opcode causes ICE

dlang · Nov 22, 2016 · d146d78 · d146d78
1 parent 1e69da3
commit d146d78
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/src/e2ir.d b/src/e2ir.d
@@ -187,6 +187,13 @@ elem *callfunc(Loc loc,
     op = fd ? intrinsic_op(fd) : -1;
     if (arguments)
     {
+        if (op == OPvector)
+        {
+            Expression arg = (*arguments)[0];
+            if (arg.op != TOKint64)
+                arg.error("simd operator must be an integer constant, not '%s'", arg.toChars());
+        }
+
         for (size_t i = 0; i < arguments.dim; i++)
         {
         Lagain:

diff --git a/test/fail_compilation/test12430.d b/test/fail_compilation/test12430.d
@@ -0,0 +1,19 @@
+/*
+REQUIRED_ARGS: -m64
+PERMUTE_ARGS:
+TEST_OUTPUT:
+---
+fail_compilation/test12430.d(18): Error: simd operator must be an integer constant, not 'op'
+---
+*/
+
+// https://issues.dlang.org/show_bug.cgi?id=12430
+
+import core.simd;
+
+void foo()
+{
+        float4 a;
+        auto op = XMM.RSQRTPS;
+        auto b = __simd(op, a);
+}