Merge pull request #6271 from LemonBoy/structfill

Fix issue 16146 - Postblit the values in struct literals.

src/init.d

@@ -246,7 +246,7 @@ extern (C++) final class StructInitializer : Initializer
 
     override Initializer semantic(Scope* sc, Type t, NeedInterpret needInterpret)
     {
-        //printf("StructInitializer::semantic(t = %s) %s\n", t->toChars(), toChars());
+        //printf("StructInitializer::semantic(t = %s) %s\n", t.toChars(), toChars());
         t = t.toBasetype();
         if (t.ty == Tsarray && t.nextOf().toBasetype().ty == Tstruct)
             t = t.nextOf().toBasetype();
@@ -329,7 +329,7 @@ extern (C++) final class StructInitializer : Initializer
                     continue;
                 }
                 value[i] = iz;
-                (*elements)[fieldi] = ex;
+                (*elements)[fieldi] = doCopyOrMove(sc, ex);
                 ++fieldi;
             }
             if (errors)

test/runnable/bug16146.d

@@ -0,0 +1,26 @@
+struct X {
+  int* rc;
+  this (int n) { auto x = new int[](1); rc = x.ptr; *rc = n; }
+  this (this)  { ++*rc; }
+  ~this ()     { --*rc; }
+  @disable void opAssign (X src);
+}
+
+struct Y {
+  X x;
+}
+
+void frob(X x)
+{
+    Y y = { x: x };
+    // The 'rc' counter starts from 1 and gets bumped when:
+    // - 'f0' is passed to 'frob'
+    // - 'y' is initialized with 'x'
+    assert(*y.x.rc == 3);
+}
+
+void main ()
+{
+    auto f0 = X(1);
+    frob(f0);
+}