Split global.params.hdrStripPlainFunctions from useInline #5733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in the original PR that added the feature (dlang#945), DMD currently triggers two entirely unrelated features with the -inline switch. Since LDC does not really have an equivalent to that switch in the first place, but users still want to control the emission of function bodies, we need to be able to control it separately. For DMD, global.params.hdrStripPlainFunctions is always set to !global.params.useInline in the driver to match the current behavior.
dnadlinger
force-pushed
the
hdrgen-inline-separate
branch
from
cfd926e
to
c36dd41
Compare
|
Auto-merge toggled on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the original PR that added the feature (#945), DMD currently
triggers two entirely unrelated features with the -inline switch. Since LDC
does not really have an equivalent to that switch in the first place, but
users still want to control the emission of function bodies, we need to be
control it separately.
For DMD, global.params.hdrStripPlainFunctions is always set to
!global.params.useInline in the driver to match the current behavior.
Ping @yebblies.