fix issue 9884 - Refused initialization of const array in the module static this() #10067
Conversation
|
Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#10067" |
| } | ||
| } | ||
|
|
||
| void main() {} |
There was a problem hiding this comment.
not necessary for a compilable test.
There was a problem hiding this comment.
Isn't -o-or -main or -lib required then
There was a problem hiding this comment.
Compilable tests have -c passed automatically.
There was a problem hiding this comment.
Why was this marked as resolved?
| @@ -8662,7 +8662,9 @@ private extern (C++) final class ExpressionSemanticVisitor : Visitor | |||
| else if (auto se = exp.e1.isSliceExp()) | |||
| { | |||
| Type tn = se.type.nextOf(); | |||
| if (exp.op == TOK.assign && !tn.isMutable()) | |||
| const fun = sc.func; | |||
| if (exp.op == TOK.assign && !tn.isMutable() && | |||
There was a problem hiding this comment.
I suggest adding a link to the bugzilla issue in the form of a comment next to or above this code. It helps to explain to the next person why it's there.
There was a problem hiding this comment.
Or, perhaps a comment describing the unique privileges of static constructors.
There was a problem hiding this comment.
Why was this marked as resolved?
There was a problem hiding this comment.
Because two lines down.
ghost
deleted the
No description provided.