Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove optabgen.d #10221

Merged
merged 1 commit into from Jul 29, 2019
Merged

remove optabgen.d #10221

merged 1 commit into from Jul 29, 2019

Conversation

WalterBright
Copy link
Member

Completes removal of optabgen.d

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10221"

@rainers
Copy link
Member

rainers commented Jul 27, 2019

Please keep CRLF for the vcxproj files.

@WalterBright WalterBright changed the title move _tysize[] and _tyalignsize[] to var.d, remove optabgen.d remove optabgen.d Jul 27, 2019
Copy link
Member

@rainers rainers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the failure on semaphoreci seems to persist: looks like the check for reproducible builds fails consistently

@thewilsonator thewilsonator merged commit 0caf1d8 into dlang:master Jul 29, 2019
@Geod24
Copy link
Member

Geod24 commented Jul 29, 2019

The SemaphoreCI failure wasn't resolved AFAICS ? And it was indeed consistent, I restarted it myself a few times...

@MartinNowak
Copy link
Member

Thanks, this inadvertently finally fixed the nightly builds which were broken on Windows with a 2.087.0 host compiler (e.g. https://buildkite.com/dlang/build-release/builds/329#b9498950-3d55-4cd8-be91-5dc305a7d527/6-8989).

@wilzbach @rainers
I guess we're not testing building dmd with the latest release version on Windows. The last release cycle also had a major nightly outage due to a Windows build error (see #10045). Can we do something akin to the SemaphoreCI tests on Windows to prevent this in the future?

The Azure job seems to run with a fixed HOST_DMD_VERSION=2.084.1 which isn't strictly necessary with our policy to only guarantee compatibility with the lastest releast dmd compiler as host. Maybe Azure could just be changed to use http://downloads.dlang.org/releases/LATEST instead of the hard-coded version?

Ability to test self-hosting and reproducible builds on Windows would also be nice, but less important.

@rainers
Copy link
Member

rainers commented Jul 31, 2019

Maybe Azure could just be changed to use http://downloads.dlang.org/releases/LATEST instead of the hard-coded version?

#10253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Easy Review Refactoring No semantic changes to code
Projects
None yet
7 participants