Rename Dsymbol.namespace to cppnamespace #10287
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Dsymbol.namespace
is apublic
extern (C++)
symbol, the C++ header generator will generate the following codeAs you know, and see from the syntax highlight,
namespace
is a C++ keyword, so this generated code won't compile.This PR renames only the public symbol
Dsymbol.namespace
.Maybe it should rename all of the
namespace
occurrences?I think, in my humble opinion, that we should avoid using other programming languages keywords as public symbols.