Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 20264 - ICE on illegal cast to vector. #10532

Merged
merged 1 commit into from Nov 4, 2019
Merged

fix issue 20264 - ICE on illegal cast to vector. #10532

merged 1 commit into from Nov 4, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 3, 2019

An assert failed in AssignExpr sema because the VectorExp created for a particular case of cast was not analysed and hence had not type.
With the fix, and since the cast was illegal, a valid TypeError is now present.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @clYd3r! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20264 critical ICE on illegal cast to vector.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10532"

An assert failed in AssignExpr sema because the VectorExp created for a particular case of cast was not analysed and hence had not type.
With the fix, and since the cast was illegal, a valid TypeError is now present.
@RazvanN7 RazvanN7 merged commit 762a831 into dlang:stable Nov 4, 2019
@ghost ghost deleted the issue-20264 branch November 4, 2019 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants