Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 20366 - fix a programming bug in ctfe foreach_reverse code #10547

Merged
merged 1 commit into from Nov 8, 2019

Conversation

SSoulaimane
Copy link
Member

Index is not decremented which causes bounds checking error.

@dlang-bot
Copy link
Contributor

dlang-bot commented Nov 7, 2019

Thanks for your pull request and interest in making D better, @SSoulaimane! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20366 critical CTFE foreach_reverse on array with utf characters crashes compiler

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10547"

SSoulaimane added a commit to SSoulaimane/dmd that referenced this pull request Nov 7, 2019
Index is not decremented which causes bounds checking error.
SSoulaimane added a commit to SSoulaimane/dmd that referenced this pull request Nov 7, 2019
Index is not decremented which causes bounds checking error.
SSoulaimane added a commit to SSoulaimane/dmd that referenced this pull request Nov 7, 2019
Index is not decremented which causes bounds checking error.
SSoulaimane added a commit to SSoulaimane/dmd that referenced this pull request Nov 7, 2019
Index is not decremented which causes bounds checking error.
SSoulaimane added a commit to SSoulaimane/dmd that referenced this pull request Nov 7, 2019
Index is not decremented which causes bounds checking error.
@thewilsonator
Copy link
Contributor

please target stable

@SSoulaimane
Copy link
Member Author

Sure.

@SSoulaimane SSoulaimane changed the base branch from master to stable November 7, 2019 23:25
@SSoulaimane SSoulaimane changed the title Fix issue 20366 - fix a programming bug in ctfe foreach_rverse code Fix issue 20366 - fix a programming bug in ctfe foreach_reverse code Nov 7, 2019
@SSoulaimane
Copy link
Member Author

Done.

Index is not decremented which causes bounds checking error.
@thewilsonator
Copy link
Contributor

Auto-merge toggled on

@thewilsonator thewilsonator merged commit 44cd826 into dlang:stable Nov 8, 2019
@SSoulaimane
Copy link
Member Author

Thanks.

SSoulaimane added a commit to SSoulaimane/dmd that referenced this pull request Nov 12, 2019
Index is not decremented which causes bounds checking error.
SSoulaimane added a commit to SSoulaimane/dmd that referenced this pull request Nov 15, 2019
Index is not decremented which causes bounds checking error.
SSoulaimane added a commit to SSoulaimane/dmd that referenced this pull request Nov 20, 2019
Index is not decremented which causes bounds checking error.
SSoulaimane added a commit to SSoulaimane/dmd that referenced this pull request Nov 20, 2019
Index is not decremented which causes bounds checking error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants