Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 20400 - increasing array length in CTFE corrupts its value #10576

Merged
merged 1 commit into from Nov 17, 2019

Conversation

SSoulaimane
Copy link
Member

@SSoulaimane SSoulaimane commented Nov 16, 2019

Issue 20400.

SSoulaimane added a commit to SSoulaimane/dmd that referenced this pull request Nov 17, 2019
Some buildkite tests started failing after making CTFE interpret `a ~= b` as `a.length++; a[$-1] = b`.
@SSoulaimane SSoulaimane marked this pull request as ready for review November 17, 2019 01:14
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @SSoulaimane! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20400 normal CTFE increasing length of array of characters changes its value

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10576"

@RazvanN7 RazvanN7 merged commit 5fda3c2 into dlang:master Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants