Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.d: Make download fail reliably #10590

Merged
merged 1 commit into from Nov 19, 2019

Conversation

MoonlightSentinel
Copy link
Contributor

download would sometimes return true on failure (caused by Issue 18318 which requires additional work in dub). This PR implements a temporary workaround and should be reverted when the issue is resolved.

See https://issues.dlang.org/show_bug.cgi?id=18318

`download` would sometimes return true on failure (caused by Issue 18318 which
requires additional work in dub). This commit implements a temporary workaround
and should be reverted when the issue is resolved.

See https://issues.dlang.org/show_bug.cgi?id=18318
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
18318 major std.net.curl.download silently ignores non-2xx http statuses

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10590"

@thewilsonator
Copy link
Contributor

Auto-merge toggled on

@thewilsonator thewilsonator merged commit e0cc6f6 into dlang:master Nov 19, 2019
@MoonlightSentinel MoonlightSentinel deleted the build-download branch December 1, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants