Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue 20416 - [Regression 2.073.2] compiler complains about escap… #10640

Merged
merged 1 commit into from Dec 7, 2019
Merged

fix Issue 20416 - [Regression 2.073.2] compiler complains about escap… #10640

merged 1 commit into from Dec 7, 2019

Conversation

WalterBright
Copy link
Member

…ing reference in certain cases

@WalterBright WalterBright added Regression PRs that fix regressions WIP Work In Progress - not ready for review or pulling labels Dec 6, 2019
@thewilsonator
Copy link
Contributor

Stable?

@WalterBright
Copy link
Member Author

The has kinda always been there. Besides, I need to still work out just how to fix it.

@thewilsonator
Copy link
Contributor

The what? (or was that supposed to be "that").

@WalterBright
Copy link
Member Author

The bug has kinda always been there. Besides, I need to still work out just how to fix it. The one here is wrong, hence WIP.

@dlang-bot
Copy link
Contributor

dlang-bot commented Dec 6, 2019 •
edited

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 20416 regression [Regression 2.073.2] compiler complains about escaping reference in certain cases

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10640"

@thewilsonator
Copy link
Contributor

So should this go to stable?

@WalterBright WalterBright removed the WIP Work In Progress - not ready for review or pulling label Dec 7, 2019
@WalterBright WalterBright changed the base branch from master to stable December 7, 2019 04:44
@WalterBright
Copy link
Member Author

It was all green before rebasing it to stable. Apparently stable doesn't build at all?

@thewilsonator
Copy link
Contributor

Circle fails with ./.circleci/run.sh: line 116: MODEL: unbound variable, semaphore is now green and build kite fails on druntime and phobos for reasons I cannot discern. But given they are also tests by the autotester I'm going to say this is good

@thewilsonator thewilsonator merged commit 9b0cd0d into dlang:stable Dec 7, 2019
@WalterBright WalterBright deleted the fix20416 branch December 7, 2019 11:17
@schveiguy
Copy link
Member

Thanks!

tramker pushed a commit to tramker/dmd that referenced this pull request Jul 24, 2020
@thewilsonator @tramker
Merge pull request dlang#10640 from WalterBright/fix20416
e15a51a 
fix Issue 20416 - [Regression 2.073.2] compiler complains about escap…

Signed-off-by: Martin Krejcirik <mk@krej.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Fix Regression PRs that fix regressions
Projects
None yet
Milestone
No milestone
4 participants
@WalterBright @thewilsonator @dlang-bot @schveiguy