Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dmd-cxx] Fix issues 19655, 19656, 19657, 19746 & 19750 (#9471) #10913

Merged
merged 2 commits into from
Mar 13, 2020

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Mar 13, 2020

A recent compiler change in #10896 meant that the bootstrap is broken, so we need to fix the host.

puneet and others added 2 commits March 13, 2020 16:59
Fix issues 19655, 19656, 19657, 19746 & 19750
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
This is a reduction of a bootstrap problem that was hit in the compiler.
@ibuclaw ibuclaw added GDC Gnu D Compiler C++ Port labels Mar 13, 2020
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
19655 regression DMD generates wrong code for some circular dependencies
19656 regression D compiler fails to resolve circular module dependency when modules are compiled separately
19657 regression D compiler fails to resolve circular module dependency when modules are compiled together
19746 regression DMD fails to compile some circular dependencies spiced with is (T == super) condition
19750 regression [Reg v2.070.2] DMD fails with some circular module refs with Template/Mixin instances

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "dmd-cxx + dmd#10913"

@ibuclaw
Copy link
Member Author

ibuclaw commented Mar 13, 2020

Windows tests always fail due to git checkout being broken...

However, I'd want to merge #10914 first to keep related changes in order.

@Geod24 Geod24 removed the auto-merge label Mar 13, 2020
@ibuclaw ibuclaw merged commit 420b220 into dlang:dmd-cxx Mar 13, 2020
@ibuclaw ibuclaw deleted the dmd-cxx-2085fixes branch March 13, 2020 18:15
kraj pushed a commit to kraj/gcc that referenced this pull request Mar 19, 2020
Fixes long standing regression in the D front-end implemention, and adds
a new field to allow retrieving a list of all content imports from the
code generator.

Reviewed-on: dlang/dmd#10913
	     dlang/dmd#10933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants