Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 20744 - Using __parameters result in function definition ca… #11162

Merged
merged 1 commit into from May 20, 2020

Conversation

BorisCarvajal
Copy link
Member

…uses wrong lookup

Run semantic on expressions inside the UDA to be sure things gets added to theirs corresponding scope.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @BorisCarvajal! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20744 enhancement Using __parameters result in function definition causes wrong lookup

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#11162"

@dlang-bot dlang-bot merged commit 3ce1bf6 into dlang:stable May 20, 2020
@Geod24
Copy link
Member

Geod24 commented May 20, 2020

Good catch! Looking at the diff, it looks like the main problem was the call to arrayExpressionSemantic and the bug with the GNU ABI tags was found this way ?

@BorisCarvajal
Copy link
Member Author

With the change I needed to flag the symbol to avoid duplicated errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants