New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 15235: inline asm: silent ICE (segfault) in asm_add_exp() #11166
Conversation
Thanks for your pull request and interest in making D better, @benjones! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11166" |
Looks like the circleci error is a debug printf statement in my fail_compile test being output... Should I change it to debug(debuga) or something that has to be enabled in the source? |
Yes, sounds like this codepath wasn't covered before, because that's definitely not a message intended for the user. |
I think this is g2g now |
return once the first memory error is found rather than falling through and goto-ing back to it a bunch of times
Also, this file looks like it could use some refactoring. I may look into that next