Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 15235: inline asm: silent ICE (segfault) in asm_add_exp() #11166

Merged
merged 2 commits into from May 23, 2020

Conversation

benjones
Copy link
Contributor

@benjones benjones commented May 19, 2020

return once the first memory error is found rather than falling through and goto-ing back to it a bunch of times

Also, this file looks like it could use some refactoring. I may look into that next

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @benjones! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
15235 normal inline asm: silent ICE (segfault) in asm_add_exp()

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11166"

@benjones
Copy link
Contributor Author

Looks like the circleci error is a debug printf statement in my fail_compile test being output... Should I change it to debug(debuga) or something that has to be enabled in the source?

@Geod24 Geod24 changed the title Fix issue 15235 Fix issue 15235: inline asm: silent ICE (segfault) in asm_add_exp() May 20, 2020
@Geod24
Copy link
Member

Geod24 commented May 20, 2020

Looks like the circleci error is a debug printf statement in my fail_compile test being output... Should I change it to debug(debuga) or something that has to be enabled in the source?

Yes, sounds like this codepath wasn't covered before, because that's definitely not a message intended for the user.

src/dmd/iasmdmd.d Outdated Show resolved Hide resolved
@benjones
Copy link
Contributor Author

I think this is g2g now

@dlang-bot dlang-bot merged commit a6883bc into dlang:master May 23, 2020
@benjones benjones deleted the fix15235 branch May 23, 2020 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants