Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests pass on single-digit days of month #11206

Merged
merged 1 commit into from Jun 2, 2020

Conversation

pbackus
Copy link
Contributor

@pbackus pbackus commented Jun 1, 2020

Previously, a regex used to match the result of DATE would fail on
the 1st through 9th of a month, because it expected one space between
the month and day instead of two.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @pbackus! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11206"

Copy link
Contributor

@MoonlightSentinel MoonlightSentinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You beat me to it

@pbackus
Copy link
Contributor Author

pbackus commented Jun 1, 2020

Tried to re-run the tests but it seems like DAutoTest is not having a good day.

Previously, a regex used to match the result of __DATE__ would fail on
the 1st through 9th of a month, because it expected one space between
the month and day instead of two.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Trivial typos, formatting, comments
Projects
None yet
5 participants