fix Issue 20958 - incomplete semantic analysis when generating code f… #11323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
|
ibuclaw
approved these changes
Jun 25, 2020
UplinkCoder
reviewed
Jun 25, 2020
| @@ -72,8 +72,6 @@ extern (C++) void semanticTypeInfo(Scope* sc, Type t) | |||
| { | |||
| if (sc) | |||
| { | |||
| if (!sc.func) | |||
There was a problem hiding this comment.
could this change get a comment?
|
Hmm it would be nice to be able to see the semantic dependency graph. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…or function
This is a fix for a regression caused by a 5 year old PR #5166
The fix is a bit risky, so it shouldn't go into stable. For example, I can find no reason for lines 75,76 to be there, but they are part of the cause for the regression.