Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 11624 - __trait(compiles) does not detect unimplemented int… #11372

Merged
merged 1 commit into from Jul 4, 2020
Merged

fix issue 11624 - __trait(compiles) does not detect unimplemented int… #11372

merged 1 commit into from Jul 4, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 4, 2020

…erface

this is just a regression test as the fix was recently brought by #11191

@dlang-bot
Copy link
Contributor

dlang-bot commented Jul 4, 2020

Thanks for your pull request and interest in making D better, @NilsLankila! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
11624 normal __trait(compiles) does not detect unimplemented interface

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11372"

@MoonlightSentinel
Copy link
Contributor

Please change the commit message as this doen't fix the issue, e.g. Add test for issue 11624 - ...

@ghost
Copy link
Author

ghost commented Jul 4, 2020

as long as autoclosing works

@ghost
Copy link
Author

ghost commented Jul 4, 2020

as suspected, auto-clsoing is now disabled

…ented interface

this is just a regression test as the fix was recently brought by #11191.

Mr dbot close issue 11624.
@MoonlightSentinel
Copy link
Contributor

MoonlightSentinel commented Jul 4, 2020

You can always close issue manually (and should mention that it was closed fixed as a side effect of another change)

@ghost
Copy link
Author

ghost commented Jul 4, 2020

okay but auto-merge quick, before i forget to close manually ;)

@MoonlightSentinel
Copy link
Contributor

MoonlightSentinel commented Jul 4, 2020

There's no need to wait for the merge - the bug is already fixed

@dlang-bot dlang-bot merged commit 4dc6ffe into dlang:master Jul 4, 2020
@ghost ghost deleted the issue-11624 branch July 4, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants