Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for Issue 21119 - Disable -betterC for coverage builds #11522

Merged
merged 2 commits into from Aug 6, 2020

Conversation

MoonlightSentinel
Copy link
Contributor

because -betterC apparently breaks coverage generation

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21119 normal Code coverage checker is not instrumenting backend source files

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11522"

@MoonlightSentinel
Copy link
Contributor Author

MoonlightSentinel commented Aug 6, 2020

Temporarily removing auto-merge to check if everything works as expected with CodeCov.

@MoonlightSentinel
Copy link
Contributor Author

Also needed to update the source file paths s.t. the *.lst are named relative to the srcdirectory (which was already done for lexer and dmd).

@MoonlightSentinel
Copy link
Contributor Author

MoonlightSentinel commented Aug 6, 2020

CodeCov works now and reports a slight coverage increase:

2020-08-06 15 12 15 codecov io 85a982a61a46

CodeCov expects *.lst files named relative to the src directory
because `-betterC` apparently breaks coverage generation
@WalterBright
Copy link
Member

Thank you! This is great.

@WalterBright WalterBright merged commit 7b71ad5 into dlang:master Aug 6, 2020
@WalterBright
Copy link
Member

@MoonlightSentinel @wilzbach -cov requires linking with druntime, and -betterC explicitly must not require druntime. This is not a bug in the backend, and this fix is not a workaround, it's a fix.

@MoonlightSentinel MoonlightSentinel deleted the backend-coverage branch June 20, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants