New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround for Issue 21119 - Disable -betterC for coverage builds #11522
Conversation
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11522" |
Temporarily removing |
5b1fac1
to
9ca3e76
Compare
Also needed to update the source file paths s.t. the |
CodeCov expects *.lst files named relative to the src directory
9ca3e76
to
3c7e9f1
Compare
because `-betterC` apparently breaks coverage generation
3c7e9f1
to
ceb3cc9
Compare
Thank you! This is great. |
@MoonlightSentinel @wilzbach -cov requires linking with druntime, and -betterC explicitly must not require druntime. This is not a bug in the backend, and this fix is not a workaround, it's a fix. |
because -betterC apparently breaks coverage generation