Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 21163 - scope lambda argument in struct init does not parse #11578

Merged
merged 1 commit into from Aug 17, 2020
Merged

fix issue 21163 - scope lambda argument in struct init does not parse #11578

merged 1 commit into from Aug 17, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 15, 2020

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @NilsLankila!

Bugzilla references

Auto-close Bugzilla Severity Description
21163 regression Scope lambda argument in struct initializer causes parsing error

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#11578"

@ghost ghost added Regression PRs that fix regressions stable-priority A regression fix to stable that should receive higher priority labels Aug 15, 2020
src/dmd/parse.d Show resolved Hide resolved
@thewilsonator
Copy link
Contributor

fatal: Remote branch v2.093.1 not found in upstream origin, please rebase to clear errors.

@ghost
Copy link
Author

ghost commented Aug 17, 2020

we do not have such a branch... maybe they want me to have the tags in sync ?

@thewilsonator
Copy link
Contributor

Hmm yeah, not sure. I'll add auto merge, it'll pass if good otherwise we'll have to come up with a different plan.

@ghost
Copy link
Author

ghost commented Aug 17, 2020

@schveiguy , "make: *** No rule to make target 'autodecode-test'. Stop." on stable branch. Looks like your work must be picked to stable ASAP. (or take a look to the problem in case my diagnostic is wrong)

@ghost
Copy link
Author

ghost commented Aug 17, 2020

shortcut to the log

@thewilsonator
Copy link
Contributor

N.B. buildkite is not technically required to pass to merge, but it would be nice to have that on stable.

@ghost
Copy link
Author

ghost commented Aug 17, 2020

ah yes, I thought that auto-tester was already green, but yeah, everybody prefers when the PRs have the green checkmark.

@ghost
Copy link
Author

ghost commented Aug 17, 2020

BTW, speaking of green checkmark, there's no formal approval yet, so merge may fail I think.

@thewilsonator
Copy link
Contributor

DMD does not require approval to merge, phobos and druntime do.

@ghost
Copy link
Author

ghost commented Aug 17, 2020

ah common, win32 test has failed after 1 hour...

timed out after 3600 seconds, step failed

@wilzbach
Copy link
Member

@schveiguy , "make: *** No rule to make target 'autodecode-test'. Stop." on stable branch. Looks like your work must be picked to stable ASAP. (or take a look to the problem in case my diagnostic is wrong)

Alternatively the buildkite check could also ignore the stable branch for now.

@schveiguy
Copy link
Member

Looks like your work must be picked to stable ASAP

Dammit, I should have targeted stable with the makefile changes...

Alternatively the buildkite check could also ignore the stable branch for now.

Yeah, the compiler is in Beta for point release, so this is going to be moot really quickly. Is it worth worrying about? Just pull PRs that everything is green except the autodecode test (glad you had me separate it into another build).

@schveiguy
Copy link
Member

auto merge will not merge with buildkite failing. so merge has to be manual.

@thewilsonator thewilsonator merged commit ece720b into dlang:stable Aug 17, 2020
@ghost
Copy link
Author

ghost commented Aug 17, 2020

thanks guys.

@ghost ghost deleted the issue-21163 branch August 17, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Bug Fix Regression PRs that fix regressions stable-priority A regression fix to stable that should receive higher priority
Projects
None yet
5 participants