fix Issue 5922 - inline assembler - referencing immutable variable va…

[WalterBright]

…lues fails

Switch to the more powerful constant folding code in the semantic routines.

[dlang-bot]

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	5922	normal	inline assembler - referencing immutable variable values fails

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11605"

[ghost]

The win32 Auto-Tester failure is recurrent. If you look at the log for the PRs that pass everywhere but not for W32 it's always the same problem.

• https://auto-tester.puremagic.com/show-run.ghtml?projectid=1&runid=4150224&isPull=true
• https://auto-tester.puremagic.com/show-run.ghtml?projectid=1&runid=4152044&isPull=true
• etc.

[WalterBright]

So might as well pull this, then, since the test failure is not relevant.

[ghost]

Yes, especially since the problem seems to be a UB in optlink.

[ghost]

Auto-merge toggled on

[WalterBright]

Looks like I can't override and pull anymore.

As for Optlink, it hasn't changed recently, so why is the test suddenly failing now?

[ghost]

Looks like I can't override and pull anymore.

I've clicked to activate automerge directly in the web interface of the Auto-Tester.

[ghost]

Auto-merge toggled off

[ghost]

That should work from GH now. I forgot that using the Auto-Tester feature to merge is only useful when external CI fail.

[WalterBright]

That should work from GH now.

What should work and what is GH? Anyhow, the "Merge pull request" box is greyed out.

[ghost]

What should work is the box that's greyed... It's possible that manual merge is disabled because the Auto-Tester is tagged as "required". So you have to amend+force push if you want to get the changes merged today.

[wilzbach]

Looks like I can't override and pull anymore.

Yes, I disabled that a while ago as it regularly lead to broken stuff being merged and Andrei directly or pushing to master. I can still be done via the settings, but it's a bit harder now with the hope of it being used less often.

Edit: It only applies to the two required CIs (Auto-Tester and DAutoTest) though. You can still merge over Buildkite failures.

[MoonlightSentinel]

The link failure + timeout suggests an internal failure in Optlink which opens it's "Message box of death"

[WalterBright]

If it's the optlink message box, it's definitely an optlink bug. It's possible an older optlink is running on that platform. If you could zip up the files that optlink is linking and email them to me, I can do some checks for simple causes.