fix Issue 15745 - Inline Assembly stomped on by Profiling #11608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11608" |
UplinkCoder
reviewed
Aug 23, 2020
| @@ -924,7 +924,7 @@ void FuncDeclaration_toObjFile(FuncDeclaration fd, bool multiobj) | |||
| * 2. impact on function inlining | |||
| * 3. what to do when writing out .di files, or other pretty printing | |||
| */ | |||
| if (global.params.trace && !fd.isCMain() && !fd.naked) | |||
| if (global.params.trace && !fd.isCMain() && !fd.naked && !(fd.hasReturnExp & 8)) | |||
There was a problem hiding this comment.
hasReturnExp & 8
needs a comment, I know what it means but others might not
There was a problem hiding this comment.
What it really needs is a refactoring of hasReturnExp into an enumeration of named flags, but refactoring that is beyond the scope of this fix. A grep of hasReturnExp will show where the bits are documented.
ghost
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is to not insert profiling instrumentation into functions with inline assembler.