Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue 6166 - Named return value optimization not dealt with in in… #11636

Merged
merged 1 commit into from Aug 28, 2020
Merged

fix Issue 6166 - Named return value optimization not dealt with in in… #11636

merged 1 commit into from Aug 28, 2020

Conversation

WalterBright
Copy link
Member

…line assembler

The fix simply disables NRVO if there is inline assembler that accesses variables.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 6166 normal Named return value optimization not dealt with in inline assembler

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11636"

@dlang-bot dlang-bot merged commit 5e37296 into dlang:master Aug 28, 2020
@WalterBright WalterBright deleted the fix6166 branch August 28, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

Assignees
No one assigned
Labels
auto-merge Bug Fix
Projects
None yet
Milestone
No milestone
3 participants
@WalterBright @dlang-bot @thewilsonator