Fix issue 21372: remove premature deprecation check.

[FeepingCreature]

Far as I can tell, without that check the deprecation just triggers later on.

Not sure if this is correct, let's see what the testsuite says.

edit: Oh yeah, I need to target stable cause it's a regression.

[dlang-bot]

Thanks for your pull request and interest in making D better, @FeepingCreature! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	21372	regression	False deprecation raised for templated overloaded struct method

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#11940"

[FeepingCreature]

Looks like deprecation of variables broke. Okay, hm. Lemme look.

[FeepingCreature]

Re-added the check only for variable declarations.

[FeepingCreature]

I think the buildkite failure is spurious. Also, what's happening with the required hanging test passes?

[thewilsonator]

Buildkite has been fixed, try force pushing.

[Geod24]

It's weird that VarDeclaration is done at this check and the rest later, and another red flag, but you got test coverage and improved the status quo, so 🤷

[Geod24]

Slight note: You can use Fix 21372: .... now in order to keep commit messages shorter.

[CyberShadow]

This pull request introduced a regression:
https://issues.dlang.org/show_bug.cgi?id=23954

[FeepingCreature]

This pull request introduced a regression:
https://issues.dlang.org/show_bug.cgi?id=23954

This pull request fixed the regression:
#15077

:-)