Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 19662 - x86_64: Different code output when compiling with i… #11944

Merged
merged 1 commit into from Jul 18, 2022

Conversation

WalterBright
Copy link
Member

…nline/boundscheck on/off

The test case from bugzilla works for me, let's see how it does in the test suite.

@dlang-bot
Copy link
Contributor

dlang-bot commented Nov 10, 2020

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
19662 major x86_64: Different code output when compiling with inline/boundscheck on/off

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11944"

@thewilsonator
Copy link
Contributor

Seems to be specifically windows x64.

@WalterBright
Copy link
Member Author

Can someone email me the object file it generates for one of the failed runs of test19662.d ?

@thewilsonator
Copy link
Contributor

sorry my windows box is out of commission. Easiest way is probably to set up DMD as a cross complier by hardcoding

enum TARGET : bool
{
    Linux        = xversion!`linux`,
    OSX          = xversion!`OSX`,
    FreeBSD      = xversion!`FreeBSD`,
    OpenBSD      = xversion!`OpenBSD`,
    Solaris      = xversion!`Solaris`,
    Windows      = xversion!`Windows`,
    DragonFlyBSD = xversion!`DragonFlyBSD`,
}

in globals.d to be

enum TARGET : bool
{
    Linux        = false,
    OSX          = false,
    FreeBSD      = false,
    OpenBSD      = false,
    Solaris      = false,
    Windows      = true,
    DragonFlyBSD = false,
}

@MoonlightSentinel
Copy link
Contributor

Can someone email me the object file it generates for one of the failed runs of test19662.d ?

test19662.zip

@Geod24
Copy link
Member

Geod24 commented Dec 8, 2020

Any update on this @WalterBright ?

@RazvanN7
Copy link
Contributor

RazvanN7 commented Jan 7, 2021

@WalterBright what is the status of this PR?

@RazvanN7 RazvanN7 merged commit ff40076 into dlang:master Jul 18, 2022
Copy link
Member

@ibuclaw ibuclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong test directory. Build is still broken.

ibuclaw added a commit that referenced this pull request Sep 5, 2022
…g with inline/boundscheck on/off (#11944)"

This reverts commit ff40076.
Geod24 pushed a commit that referenced this pull request Sep 6, 2022
…g with inline/boundscheck on/off (#11944)"

This reverts commit ff40076.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants