dmd.mars: Add method to predefine FreeBSD_12 at compile-time. #11982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibuclaw
requested review from
Geod24,
MartinNowak,
rainers,
UplinkCoder and
WalterBright
as code owners
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11982" |
ibuclaw
force-pushed
the
freebsd12
branch
2 times, most recently
from
0429e42
to
1b17b11
Compare
This allows to statically set which version of FreeBSD to compile for using DFLAGS, choices are FreeBSD 10, 11 or 12. If unset, the default is to use the same version as the host, or fallback to version 11 if compiling on a different host, or using an old D compiler to build DMD. To be decided is whether there should be a dynamic way of detecting the FreeBSD OS version as well, such as by using getosreldate().
thewilsonator
approved these changes
Nov 19, 2020
ibuclaw
commented
Nov 20, 2020
| @@ -71,6 +71,7 @@ task: | |||
| timeout_in: 60m | |||
| environment: | |||
| OS_NAME: freebsd | |||
| CI_DFLAGS: -version=TARGET_FREEBSD12 | |||
There was a problem hiding this comment.
No idea why dmd fails to compile with src/core/checkedint.d(691): Error: divide by zero if DFLAGS is exported in the environment.
This was referenced Nov 20, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to statically set which version of FreeBSD to compile for using DFLAGS, choices are FreeBSD 10, 11 or 12. If unset, the default is to use the same version as the host, or fallback to version 11 if compiling on a different host, or using an old D compiler to build DMD.
To be decided is whether there should be a dynamic way of detecting the FreeBSD OS version as well, such as by using getosreldate().
Small reboot of the stalled PR #8567