Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give the proper Loc information when calling assert hook #11987

Merged
merged 1 commit into from Nov 23, 2020
Merged

Give the proper Loc information when calling assert hook #11987

merged 1 commit into from Nov 23, 2020

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Nov 23, 2020 

Before this change, if calling the internal _d_assert_fail hook failed,
no file/line informations were provided, making it hard to track down
the origin of the error.
Obviously, calling _d_assert_fail is done by the compiler and should never
result in an error in the first place, but if it does, we can now see why.

@Geod24
Give the proper Loc information when calling assert hook
e29a7ab 
Before this change, if calling the internal _d_assert_fail hook failed,
no file/line informations were provided, making it hard to track down
the origin of the error.
Obviously, calling _d_assert_fail is done by the compiler and should never
result in an error in the first place, but if it does, we can now see why.
@Geod24 Geod24 added the Trivial typos, formatting, comments label Nov 23, 2020
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @Geod24!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11987"

@Geod24 Geod24 mentioned this pull request Nov 23, 2020
Draft
@dlang-bot dlang-bot merged commit 6f8ead9 into dlang:master Nov 23, 2020
@Geod24 Geod24 deleted the checkaction-context-errors branch November 23, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoonlightSentinel MoonlightSentinel MoonlightSentinel approved these changes

Assignees
No one assigned
Labels
auto-merge Trivial typos, formatting, comments
Projects
None yet
Milestone
No milestone
3 participants
@Geod24 @dlang-bot @MoonlightSentinel