fix Issue 10445 - add .min, .max, etc. properties for vector types #12045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#12045" |
thewilsonator
approved these changes
Dec 22, 2020
thewilsonator
added
the
Needs Spec PR
WalterBright
force-pushed
the
fix10445
branch
2 times, most recently
from
71c096d
to
4f17dad
Compare
WalterBright
force-pushed
the
fix10445
branch
from
4f17dad
to
06c122f
Compare
WalterBright
force-pushed
the
fix10445
branch
from
06c122f
to
ff88025
Compare
|
Spec PR ? |
ibuclaw
requested changes
Dec 22, 2020
|
|
||
| int main() | ||
| { | ||
| version (D_SIMD) |
There was a problem hiding this comment.
Test doesn't depend on this version condition.
rtbo
pushed a commit
to rtbo/dmd
that referenced
this pull request
Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because one would expect these to work.