Fix 21472 - Support tuple comparison with -checkaction=context (2/2)
#12055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoonlightSentinel
force-pushed
the
checkaction-tuples
branch
from
c108c9a
to
692f6ef
Compare
MoonlightSentinel
force-pushed
the
checkaction-tuples
branch
from
bff6b7a
to
0ba0839
Compare
Detect `TupleExp` used inside the `assert` and redirect them to a new variadic hook in druntime (see dlang/druntime#3318). Example: ```d alias a = AliasSeq!(...); alias b = AliasSeq!(...); assert(a == b); ``` This assertion will call: ```d _d_assert_fail!("==", typeof(a))(a, b); ```
MoonlightSentinel
force-pushed
the
checkaction-tuples
branch
from
0ba0839
to
ec68ec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect
TupleExpused inside theassertand redirect them to a new variadic hook in druntime (see dlang/druntime#3318).Example:
This assertion will call: