Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 21501 - undefined identifier in package when using mixin an… #12074

Merged
merged 1 commit into from Dec 30, 2020

Conversation

BorisCarvajal
Copy link
Member

…d cyclic imports

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @BorisCarvajal! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21501 regression [REG 2.089.1] undefined identifier in package when using mixin and cyclic imports

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12074"

src/dmd/dimport.d Outdated Show resolved Hide resolved
@thewilsonator
Copy link
Contributor

This is a regression please target stable.

@BorisCarvajal
Copy link
Member Author

This is a regression please target stable.

Strictly speaking it never worked, it just happens that in one point release interval (because a change to mixin) the code using the mixins case compiled.
And as I commented in bugzilla, the bug is not related to mixin but any DotExpression.

@thewilsonator
Copy link
Contributor

OK

@dlang-bot dlang-bot merged commit 98b7320 into dlang:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants