Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue 11717 - CTFE: non-constant value with array and vector ops #12083

Merged
merged 1 commit into from Jan 2, 2021
Merged

fix Issue 11717 - CTFE: non-constant value with array and vector ops #12083

merged 1 commit into from Jan 2, 2021

Conversation

WalterBright
Copy link
Member

This enables the CTFE to work on array operations, including vector types.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 11717 critical CTFE: non-constant value with array and vector ops.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12083"

@WalterBright
Copy link
Member Author

This bug has been around since Day 1 of CTFE. I don't think it needs to go into stable.

ibuclaw
ibuclaw reviewed Dec 31, 2020
View reviewed changes
src/dmd/dinterpret.d Outdated
/******************************************
* Perform the operation fp on operands e1 and e2.
*/
UnionExp evalu8(Loc loc, Type type, Expression e1, Expression e2)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a better name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion?

Copy link
Member

@ibuclaw ibuclaw Jan 1, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

evaluate would be a good start... evaluateBinExp ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@dlang-bot dlang-bot merged commit 6b0c5bb into dlang:master Jan 2, 2021
@WalterBright WalterBright deleted the fix11717 branch January 2, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibuclaw ibuclaw ibuclaw approved these changes

Assignees
No one assigned
Labels
auto-merge Bug Fix
Projects
None yet
Milestone
No milestone
3 participants
@WalterBright @dlang-bot @ibuclaw