merge stable #12088
Merged
merge stable #12088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MartinNowak
commented
Jan 1, 2021
MartinNowak
commented
- Fix duplicate function detection for extern(C) member funtions
- fix Issue 21514 - [ICE] cod1.d:4015: Assertion `retregs || !*pretregs' failed with -m32
- fix Issue 20652 - extern(C++) doesn't seem to mangle the types in core.simd right
- bump VERSION to v2.095.0
- purge changelog
`extern(C)` member functions are mangled as `extern(D)` (while still following `C` ABI) because it's deemed more useful for callbacks, etc. The previous implementation didn't consider this special case and always issued a deprecation message even though there would be no error once the deprecation ends (because the mangling is actually different). This commit ensures that the deprecation is only issued for non-member functions.
…' failed with -m32
|
Thanks for your pull request, @MartinNowak! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#12088" |
MoonlightSentinel
approved these changes
Jan 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.