fix Issue 21614 - AssertError@src/dmd/semantic3.d(812): Assertion failure #12191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#12191" |
|
Sounds definitely worth targeting |
|
Yes, please target stable. |
ibuclaw
requested review from
andralex,
CyberShadow,
Geod24,
jacob-carlborg,
kinke,
MartinNowak,
rainers,
RazvanN7,
UplinkCoder and
WalterBright
as code owners
…lure Template instances may import modules that have not finished semantic1, and in the case of cyclic imports, semantic2 could be ran on a function symbol before semantic1 has begun, which can lead to auto functions given the wrong return type.
|
Rebased, though having it in master would allow it to be a bit more readily tested. |
RazvanN7
approved these changes
Feb 11, 2021
|
The code added is harmless and fixes an ICE, so I see no reason why we should be extra cautious. |
Changing the order that semantic runs in is never harmless IMO, especially considering bugs such as issue 20753 :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template instances may import modules that have not finished semantic1, and in the case of cyclic imports, semantic2 could be ran on a function symbol before semantic1 has begun, which can lead to auto functions given the wrong return type.