Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 21687 - Confusing error message for CTFE #12287

Merged
merged 6 commits into from Mar 19, 2021
Merged

Fix issue 21687 - Confusing error message for CTFE #12287

merged 6 commits into from Mar 19, 2021

Conversation

Imperatorn
Copy link
Contributor

Probably needs a "proper" fix, but this works for now.

The initializer expression appears in the source code as new int, but is printed as &[0][0]

This patch changes the error message to show the expression before ctfeInterpret, for example new int instead of &[0][0]

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Imperatorn! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21687 regression Confusing error message for CTFE pointer in static initializer

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#12287"

@Geod24 Geod24 merged commit 75fe50f into dlang:stable Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants