Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for importC issues 21933, 21965, 21968, 21973. #12598

Merged
merged 4 commits into from May 28, 2021

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented May 27, 2021

As of #12594, none of these tests are causing an ICE in the compiler. However there seems to be a issue resolving names in some cases.

@ibuclaw ibuclaw added Easy Review ImportC Pertaining to ImportC support labels May 27, 2021
@ibuclaw ibuclaw requested a review from WalterBright May 27, 2021 21:44
@dlang-bot
Copy link
Contributor

dlang-bot commented May 27, 2021

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
21933 critical importC: struct parameters: AssertError@src/dmd/typesem.d(1890): Assertion failure
21965 critical importC: Anonymous top-level struct or union triggers AssertError@dsymbolsem.d(4787)
21968 critical importC: struct fields: AssertError@src/dmd/typesem.d(1890): Assertion failure
21973 critical importC: AssertError@src/dmd/dsymbolsem.d(4307): Assertion failure

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12598"

@thewilsonator thewilsonator merged commit c56ed98 into dlang:master May 28, 2021
@ibuclaw ibuclaw deleted the cparse-bugs branch May 28, 2021 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Easy Review ImportC Pertaining to ImportC support
Projects
None yet
4 participants