Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Issue 19234 - betterC TypeInfo error when using slice copy on Structs #12651

Merged
merged 1 commit into from Jun 9, 2021
Merged

Extend Issue 19234 - betterC TypeInfo error when using slice copy on Structs #12651

merged 1 commit into from Jun 9, 2021

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Jun 8, 2021

As with other tests, also allow compilation to succeed when TypeInfo is non-existent.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
✗ 19234 normal betterC TypeInfo error when using slice copy on Structs

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12651"

@ibuclaw ibuclaw added the Blocking Other Work review and pulling should be a priority label Jun 8, 2021
@ibuclaw
Copy link
Member Author

ibuclaw commented Jun 8, 2021

This is blocking the fix for issue 22005.

thewilsonator
thewilsonator approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

test/compilable/minimal3.d Show resolved Hide resolved
@ibuclaw
Copy link
Member Author

ibuclaw commented Jun 9, 2021

Waking up azure pipelines.

@dlang-bot dlang-bot merged commit 51d8e1e into dlang:master Jun 9, 2021
@ibuclaw ibuclaw deleted the issue19234 branch June 9, 2021 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

Assignees
No one assigned
Labels
auto-merge Blocking Other Work review and pulling should be a priority Bug Fix Easy Review
Projects
None yet
Milestone
No milestone
3 participants
@ibuclaw @dlang-bot @thewilsonator