Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 22106 - importC: Error: variable 'var' no definition of struct 'type' #12820

Merged
merged 1 commit into from Jul 7, 2021

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Jul 6, 2021

The resolved TypeTag was not pushed into the scope's symtab, so subsequent scope searches failed.

@ibuclaw ibuclaw added Bug Fix ImportC Pertaining to ImportC support labels Jul 6, 2021
@ibuclaw ibuclaw requested a review from WalterBright July 6, 2021 10:22
@dlang-bot
Copy link
Contributor

dlang-bot commented Jul 6, 2021

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
22106 critical importC: Error: variable 'var' no definition of struct 'type'

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12820"

@thewilsonator
Copy link
Contributor

Why are these importC bugs being marked so high priority?

@ibuclaw
Copy link
Member Author

ibuclaw commented Jul 6, 2021

Why are these importC bugs being marked so high priority?

QA issues blocking people from import header seamlessly. We do not want to have first release with importC in a broken state.

@ibuclaw ibuclaw closed this Jul 7, 2021
@ibuclaw ibuclaw reopened this Jul 7, 2021
@dlang-bot dlang-bot merged commit f948db1 into dlang:master Jul 7, 2021
@ibuclaw ibuclaw deleted the issue22106 branch July 7, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Bug Fix ImportC Pertaining to ImportC support
Projects
None yet
4 participants