Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue 22122 - [REG 2.097][ICE] Segmentation fault in in dmd.access.hasPackageAccess #12867

Merged
merged 1 commit into from Jul 13, 2021
Merged

fix Issue 22122 - [REG 2.097][ICE] Segmentation fault in in dmd.access.hasPackageAccess #12867

merged 1 commit into from Jul 13, 2021

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Jul 13, 2021 •
edited

Due to the change in #12439, the pushed scope for try bodies are not set-up correctly, resulting in the parent chain of resolved Dsymbol's severed of their enclosing Package/Module.

This patch changes the regressing commit to go through semanticScope instead, which sets up the scope parent properly.

@ibuclaw ibuclaw added Regression PRs that fix regressions Industry Applies to PRs pertaining to industry applications of D labels Jul 13, 2021
@dlang-bot
Copy link
Contributor

dlang-bot commented Jul 13, 2021 •
edited

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 22122 regression [REG 2.097][ICE] Segmentation fault in in dmd.access.hasPackageAccess

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#12867"

@RazvanN7
Copy link
Contributor

Please target stable

@ibuclaw ibuclaw changed the base branch from master to stable July 13, 2021 19:18
@ibuclaw
Copy link
Member Author

ibuclaw commented Jul 13, 2021

Please target stable

GitHub is stupid and doesn't detect that base of the originating branch is already on stable.

@ibuclaw
Copy link
Member Author

ibuclaw commented Jul 13, 2021 •
edited

Added try-catch test, as it also segfaults.

@dlang-bot dlang-bot merged commit f2fbdca into dlang:stable Jul 13, 2021
@ibuclaw ibuclaw deleted the issue22122 branch July 14, 2021 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RazvanN7 RazvanN7 RazvanN7 approved these changes

@MoonlightSentinel MoonlightSentinel MoonlightSentinel approved these changes

Assignees
No one assigned
Labels
auto-merge Bug Fix Industry Applies to PRs pertaining to industry applications of D Regression PRs that fix regressions
Projects
None yet
Milestone
No milestone
4 participants
@ibuclaw @dlang-bot @RazvanN7 @MoonlightSentinel