Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 22157 - Bad diagnostic for static/non-static overload resolution conflict #12958

Merged
merged 1 commit into from Aug 6, 2021

Conversation

RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Aug 5, 2021

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Aug 5, 2021

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22157 regression Bad diagnostic for static/non-static overload resolution conflict

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#12958"

@RazvanN7 RazvanN7 changed the base branch from master to stable August 5, 2021 13:04
@RazvanN7 RazvanN7 added Regression PRs that fix regressions Easy Review labels Aug 5, 2021
Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

src/dmd/expressionsem.d Outdated Show resolved Hide resolved
@RazvanN7
Copy link
Contributor Author

RazvanN7 commented Aug 6, 2021

It seems that the macOS tester has hanged.

@RazvanN7 RazvanN7 merged commit 1963056 into dlang:stable Aug 6, 2021
@MartinNowak MartinNowak mentioned this pull request Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants