fix Issue 22253 - ImportC expressions inadvertently supporting D properties #13066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#13066" |
WalterBright
force-pushed
the
fix22253
branch
7 times, most recently
from
55493dd
to
44ca0ed
Compare
RazvanN7
reviewed
Sep 13, 2021
| @@ -9,7 +9,7 @@ struct S *abc = &(struct S){ 1, 2 }; | |||
| int test() | |||
| { | |||
| struct S *var = &(struct S){ 1, 2 }; | |||
| return var.b; | |||
| return var->b; | |||
RazvanN7
approved these changes
Sep 13, 2021
|
Could you please create a bugzilla entry and link it to this PR? |
RazvanN7
added
the
Needs Bug Report
|
What's up with this PR title? |
WalterBright
force-pushed
the
fix22253
branch
from
44ca0ed
to
0733ba8
Compare
WalterBright
changed the title
WalterBright
added
auto-merge
and removed
Needs Bug Report
|
@ibuclaw @WalterBright looks like this may have caused this https://issues.dlang.org/show_bug.cgi?id=22322 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to prevent the compiler from looking up properties for C structs. Unfortunately, the property code lookup is a byzantine mess. So, what this fix does is short-circuit the mess and do its own lookup in importc.d.
A future PR could add spell checking to it.