Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdrgen: remove trailing whitespace on attribute declarations #13121

Merged
merged 1 commit into from Oct 5, 2021

Conversation

ljmf00
Copy link
Member

@ljmf00 ljmf00 commented Oct 3, 2021

Fixes Issue 22353.

Signed-off-by: Luís Ferreira contact@lsferreira.net

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ljmf00! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22353 enhancement Header generation is producing trailing whitespace on attribute declarations

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13121"

@ljmf00 ljmf00 force-pushed the remove-trailing-whitespaces-hdrgen branch 3 times, most recently from 5995579 to ffa3c7b Compare October 3, 2021 19:43
@ljmf00 ljmf00 marked this pull request as ready for review October 3, 2021 20:52
src/dmd/hdrgen.d Outdated Show resolved Hide resolved
src/dmd/hdrgen.d Outdated Show resolved Hide resolved
Fixes Issue 22353.

Signed-off-by: Luís Ferreira <contact@lsferreira.net>
@ljmf00 ljmf00 force-pushed the remove-trailing-whitespaces-hdrgen branch from ffa3c7b to 2e7c7ee Compare October 4, 2021 00:07
@thewilsonator
Copy link
Contributor

please rebase to restart CI

@dlang-bot dlang-bot merged commit 5394ae6 into dlang:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants