Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 21850 - [REG2.093] Template inference of pure not working #13137

Merged
merged 1 commit into from Oct 7, 2021

Conversation

BorisCarvajal
Copy link
Member

This was wrongly passing the original scope when checking for alias this on parameters.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @BorisCarvajal!

Bugzilla references

Auto-close Bugzilla Severity Description
21850 regression [REG2.093] Template inference of pure not working

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#13137"

@thewilsonator
Copy link
Contributor

is this pr based on the head of dlang/stable? if not rebasing might solve the CI failure.

@BorisCarvajal
Copy link
Member Author

is this pr based on the head of dlang/stable? if not rebasing might solve the CI failure.

Yes, look the autotester rerun and now the error is gone.

@dlang-bot dlang-bot merged commit 276dd52 into dlang:stable Oct 7, 2021
@kinke
Copy link
Contributor

kinke commented Oct 18, 2021

@BorisCarvajal: This has unfortunately caused/triggered a regression: https://issues.dlang.org/show_bug.cgi?id=22420

@BorisCarvajal
Copy link
Member Author

I also hit this running automem test suit (it seems some tests are disabled by default).
I have an alternative fix ready, gonna push it in a couple of hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants