Switch to the new CodeCov uploader #13139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#13139" |
MoonlightSentinel
force-pushed
the
ci/migrate-codecov
branch
5 times, most recently
from
d251e63
to
af447bc
Compare
|
Azure also? |
|
Next one on the list after Cirrus |
MoonlightSentinel
force-pushed
the
ci/migrate-codecov
branch
3 times, most recently
from
6518a58
to
9b32d0b
Compare
ljmf00
requested changes
Oct 8, 2021
There was a problem hiding this comment.
We should think of adding https://pre-commit.com/ and shellcheck to the CI checks to check these trivial changes.
MoonlightSentinel
force-pushed
the
ci/migrate-codecov
branch
from
5a1565b
to
57ba223
Compare
MoonlightSentinel
force-pushed
the
ci/migrate-codecov
branch
9 times, most recently
from
08aaf36
to
07bbf94
Compare
The currently used bash uploader is deprecated and will be removed in the future[1]. This commit replaces the existing setup with the new uploader for all currently supported platforms as proposed in [2]. Additional notes: - FreeBSD support isn't supported yet and keeps using the old uploader - Moved the new implementation into a dedicated file `source`d by all coverage CI's (instead of changing each individual configuration) [1] https://about.codecov.io/blog/codecov-uploader-deprecation-plan [2] https://about.codecov.io/blog/introducing-codecovs-new-uploader
MoonlightSentinel
force-pushed
the
ci/migrate-codecov
branch
from
07bbf94
to
53d7fae
Compare
MoonlightSentinel
changed the title
RazvanN7
approved these changes
Oct 27, 2021
MoonlightSentinel
added a commit
to MoonlightSentinel/druntime
that referenced
this pull request
Oct 27, 2021
Reuse the script introduced in dlang/dmd#13139
MoonlightSentinel
added a commit
to MoonlightSentinel/phobos
that referenced
this pull request
Oct 27, 2021
Reuse the script introduced in dlang/dmd#13139
dlang-bot
pushed a commit
to dlang/druntime
that referenced
this pull request
Oct 27, 2021
Reuse the script introduced in dlang/dmd#13139
dlang-bot
pushed a commit
to dlang/phobos
that referenced
this pull request
Oct 27, 2021
Reuse the script introduced in dlang/dmd#13139
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The currently used bash uploader is deprecated and will be removed in
the future[1]. This commit replaces the existing setup with the new
uploader for all currently supported platforms as proposed in [2].
Additional notes:
sourced byall coverage CI's (instead of changing each individual configuration)
[1] https://about.codecov.io/blog/codecov-uploader-deprecation-plan
[2] https://about.codecov.io/blog/introducing-codecovs-new-uploader