Partial fix issue 19294 - Support for array operations with Complex! is incomplete

[sorin-gabriel]

…plete (partial fix, only for operands of the same type)

The git diff isn't very helpful here, as the only real changes are the removal of the return statement and the outer if condition. The if condition is redundant and the early return caused the compiler to throw errors for array operations like T[] op T or T op T[]

This is a partial fix for the issue, as T[] op U, U op T[] or T[] op U[] still aren't covered, even when op overload is defined.

[dlang-bot]

Thanks for your pull request and interest in making D better, @sorin-gabriel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✗	19294	normal	Support for array operations with Complex! is incomplete

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13154"

[thewilsonator]

Please add the test case(s) from the bug report.

[thewilsonator]

since this is a partial fix, please remove the word fix from the commit message of the first commit since this doesn't completely fix the issue. (the bot should update its message to reflect that fact).

[thewilsonator]

this is not needed

[thewilsonator]

replace this with an inline definition of Complex the test suite is not allowed t depend on the standard library. a simple

struct Complex(T)
{
     T re, im;
    // Methods (i.e. opBinary and opBinaryRight) + alias this
    // and anything else necessary to reproduce the bug
}

should suffice, no need for the body of the methods, just a return this; should be fine.

[RazvanN7]

The issue is not with Complex, but with any user-defined type that has an opBinary.

[thewilsonator]

test functions in compilable should not be main functions.

[RazvanN7]

You still need to rebase to get rid of "Fix" from the commit message.

Addressed

[sorin-gabriel]

Wanted to click "View details", but clicked on "Revert" instead. Please ignore.